Skip to content

Add contributor guide and pull request template#164

Merged
yysskk merged 1 commit into
mainfrom
docs/contributing
Jul 7, 2026
Merged

Add contributor guide and pull request template#164
yysskk merged 1 commit into
mainfrom
docs/contributing

Conversation

@yysskk

@yysskk yysskk commented Jul 7, 2026

Copy link
Copy Markdown
Owner

Summary

Lowers the barrier to a first contribution by documenting the workflow that until now lived only in scattered README lines and CI files.

  • CONTRIBUTING.md: requirements, project layout, how to build and test the package, how to generate and run the example app (XcodeGen), the swift format lint/format commands, the DocC build (--warnings-as-errors), and the changelog + pull-request conventions.
  • .github/PULL_REQUEST_TEMPLATE.md: a short checklist that mirrors what CI enforces (tests, formatter-clean, DocC for public API changes, changelog for user-facing changes).
  • README: the Contributing section now links the guide and keeps the one-line test command.

Notes

  • Docs and template only — no source or CI changes.
  • The guide's swift format section describes the tooling introduced in Adopt swift-format for linting and formatting #163; that PR should merge first so the referenced .swift-format config is present on main.
  • The example test command in the README keeps iPhone 16 as an illustrative device name (any installed simulator works).

Comment thread CONTRIBUTING.md
Comment thread CONTRIBUTING.md
Comment thread CONTRIBUTING.md
Comment thread .github/PULL_REQUEST_TEMPLATE.md

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs-only PR (CONTRIBUTING.md, PR template, README pointer) — no code changes. The content is otherwise clear and matches the actual CI setup (Xcode 26 / Swift 6.2, xcodegen, docbuild) except for one recurring inaccuracy: CONTRIBUTING.md and the PR template both describe a swift format lint --strict requirement backed by a .swift-format config and a CI check, but neither the config file nor a swift-format CI job exists in this repo (.github/workflows/test.yml only runs package tests, example build, and docbuild). This will mislead contributors into thinking there's a formatting gate that isn't actually enforced. Please either add the .swift-format config and a CI job, or update the docs/template to stop claiming this check exists.

Add a CONTRIBUTING.md documenting the toolchain, how to build and run
the package and the generated example app, the swift-format lint/format
workflow, the DocC build, and the changelog and pull-request
conventions. Add a PULL_REQUEST_TEMPLATE.md whose checklist mirrors what
CI enforces, and link the guide from the README's Contributing section.
@yysskk yysskk force-pushed the docs/contributing branch from 529e9fa to 40f693b Compare July 7, 2026 16:59

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs-only PR (CONTRIBUTING.md, PR template, README pointer). Verified the previously-flagged inaccuracy is resolved: .swift-format now exists and .github/workflows/test.yml has a swift-format lint/format-check job (landed via #163, merged into main and rebased in). All other claims in CONTRIBUTING.md (project layout, Swift Testing usage, xcodebuild commands, docbuild flags, CHANGELOG conventions) match the current repo state. No bugs or issues found.

@yysskk yysskk merged commit 70ecdf9 into main Jul 7, 2026
5 checks passed
@yysskk yysskk deleted the docs/contributing branch July 7, 2026 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant